3145 path selector error handling #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Oct 31, 2023
apps/dashboard/app/javascript/path_selector/path_selector_data_table.js
Outdated
Show resolved
Hide resolved
johrstrom
reviewed
Oct 31, 2023
apps/dashboard/app/views/batch_connect/session_contexts/_path_selector.html.erb
Outdated
Show resolved
Hide resolved
johrstrom
reviewed
Oct 31, 2023
| $(`#${this.tableId}_wrapper`).show(); | ||
| this.resetTable(); | ||
| if (err.message.match("Permission denied")) { | ||
| $('#forbidden-warning').show(); |
There was a problem hiding this comment.
I think we should also focus this element at this point. If you've scrolled down past it, you can't really see it. I had to set the tabindex=0 to get it to work.
Also note that focus() is deprecated so we'd want .trigger("focus") (in jQuery).
johrstrom
reviewed
Oct 31, 2023
| @@ -43,6 +43,11 @@ | |||
| <div> | |||
| <ol id="<%= breadcrumb_id %>" class="breadcrumb breadcrumb-no-delimiter"> | |||
| </ol> | |||
|
|
|||
| <div class="alert alert-warning" role="alert" id="forbidden-warning"> | |||
There was a problem hiding this comment.
This is going to throw off the use of hide and show APIs because they set the styles, but I feel like this should default to class=d-none because sometimes it shows up on initial load (at least for a second) before the javascript runs to hide it.
johrstrom
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3145
Screen.Recording.2023-10-31.at.9.54.31.AM.mov