Add cloud icons for remote favorite paths #3076
Conversation
| <li class="nav-item"><%= link_to p.title || p.path.to_s, files_path(p.filesystem, p.path.to_s), class: "nav-link d bg-light" %> | ||
| <li class="nav-item"> | ||
| <%= link_to files_path(p.filesystem, p.path.to_s), class: "nav-link d bg-light" do %> | ||
| <%= fa_icon "cloud", classes: '' %> |
There was a problem hiding this comment.
I've got to look this over - it looks like you've hard coded cloud icons for all favorite paths, so I'm either misreading it or something.
There was a problem hiding this comment.
Hmm, let me double check that. Seems like some code may have gone missing.
There was a problem hiding this comment.
It had indeed gone missing. Added it now.
robinkar
force-pushed
the
remote-storage-icons
branch
from
3d41c92 to
5140353
Compare
| <li class="nav-item"><%= link_to p.title || p.path.to_s, files_path(p.filesystem, p.path.to_s), class: "nav-link d bg-light" %> | ||
| <li class="nav-item"> | ||
| <%= link_to files_path(p.filesystem, p.path.to_s), class: "nav-link d bg-light" do %> | ||
| <%= fa_icon "cloud", classes: '' if p.remote? %> |
There was a problem hiding this comment.
I see what I'm missing - these links didn't have icons at all! Doesn't seem like we can use icon_uri here, but maybe a helper to determine the icon? That we we get folders and clouds.
There was a problem hiding this comment.
Added icons for the other favorite paths, and also Home Directory for consistency. Although I wonder if we could rely more directly on the OodAppLinks here.
Use folder icon for normal favorite paths, which previously had no icon.
This PR adds cloud icons for favorite paths for remote storages both in the navbar and in the file browser.
The navbar items are currently somewhat ugly due to the spacing, but that is fixed in my other open PR (#3075).