Fixes bug where icon shows up on 2nd path_selector on page (#4009)

* Fixes bug where icon shows up on 2nd path_selector on page * Fixes HTML
OSC · Dec 12, 2024 · dd9d8c0 · dd9d8c0
1 parent 0b460fb
commit dd9d8c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/apps/dashboard/app/javascript/path_selector/path_selector_data_table.js b/apps/dashboard/app/javascript/path_selector/path_selector_data_table.js
@@ -84,7 +84,7 @@ export class PathSelectorTable {
   async reloadTable(url) {
     try {
       $(this.tableWrapper()).hide();
-      $('#loading-icon').show();
+      $(this).closest('.loading-icon').show();
       const response = await fetch(url, { headers: { 'Accept': 'application/json' }, cache: 'no-store' });
       const data = await this.dataFromJsonResponse(response);
       $(`#${this.breadcrumbId}`).html(data.path_selector_breadcrumbs_html);
@@ -104,7 +104,7 @@ export class PathSelectorTable {
   }
 
   resetTable() {
-    $('#loading-icon').hide();
+    $(this).closest(".loading-icon").hide();
     $(this.tableWrapper()).show();
     $('#forbidden-warning').addClass('d-none');
   }

diff --git a/apps/dashboard/app/views/shared/_path_selector_table.html.erb b/apps/dashboard/app/views/shared/_path_selector_table.html.erb
@@ -45,7 +45,7 @@
               </div>
 
               <div class="d-flex justify-content-center">
-                <div id="loading-icon" class="spinner-border rem-5" role="status">
+                <div class="loading-icon spinner-border rem-5" role="status">
                   <span class="sr-only">Loading...</span> 
                 </div>
               </div>