Do not put NodeJS repo into Ubuntu 24.04 build image #281
Conversation
| @@ -32,7 +32,7 @@ RUN apt update -y && apt install -y apt-transport-https ca-certificates \ | |||
| init debhelper devscripts dh-make build-essential apt-cudf lintian equivs \ | |||
| sudo rake wget curl ruby bundler && \ | |||
| apt clean all -y | |||
| <% if ! ['bookworm'].include?(codename) && arch != 'ppc64le' %> | |||
| <% if ! ['noble', 'bookworm'].include?(codename) && arch != 'ppc64le' %> | |||
There was a problem hiding this comment.
Seems like it's more future resistant to just have codename == 'bookworm'? I mean won't this break/need updating when 26.04 comes out?
There was a problem hiding this comment.
Errr sorry, I'm getting turned around codename == jammy? I can't recall the 22 & 20 codenames, but it seems like it should check for those so that future releases won't need this update.
There was a problem hiding this comment.
Ya, actually should probably do like:
if ['focal', 'jammy'].include?(codename) && arch != 'ppc64le'
This assumes that the older Ubuntu releases will be last Debian/Ubuntu releases with ancient OS NodeJS
There was a problem hiding this comment.
Also FYI, codenames we support:
ondemand-packaging/lib/ood_packaging/build_box.rb
Lines 22 to 27 in c099b1a
Fixes #280