Apply suggestions from code review

Co-authored-by: Mark Hoemmen <[email protected]>
ORNL · Mar 22, 2024 · 24caa05 · 24caa05
1 parent a587310
commit 24caa05
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/mdspan_copy/mdspan_copy.md b/mdspan_copy/mdspan_copy.md
@@ -39,18 +39,18 @@ Finally, there is some question as to whether `copy` and `fill` should return a
 ```c++
 template<class SrcElementType, class SrcExtents, class SrcLayoutPolicy, class SrcAccessorPolicy,
          class DstElementType, class DstExtents, class DstLayoutPolicy, class DstAccessorPolicy>
-void copy(const mdspan<SrcElementType, SrcExtents, SrcLayoutPolicy, SrcAccessorPolicy> &src, const mdspan<DstElementType, DstExtents, DstLayoutPolicy, DstAccessorPolicy> &dst)
+void copy(mdspan<SrcElementType, SrcExtents, SrcLayoutPolicy, SrcAccessorPolicy> src, mdspan<DstElementType, DstExtents, DstLayoutPolicy, DstAccessorPolicy> dst);
 
 template<class ExecutionPolicy, class SrcElementType, class SrcExtents, class SrcLayoutPolicy, class SrcAccessorPolicy,
          class DstElementType, class DstExtents, class DstLayoutPolicy, class DstAccessorPolicy>
-void copy(ExecutionPolicy&& policy, const mdspan<SrcElementType, SrcExtents, SrcLayoutPolicy, SrcAccessorPolicy> &src, const mdspan<DstElementType, DstExtents, DstLayoutPolicy, DstAccessorPolicy> &dst)
+void copy(ExecutionPolicy&& policy, mdspan<SrcElementType, SrcExtents, SrcLayoutPolicy, SrcAccessorPolicy> src, mdspan<DstElementType, DstExtents, DstLayoutPolicy, DstAccessorPolicy> dst);
 ```
 
 [1]{.pnum} *Constraints:*
 
-  * [1.1]{.pnum} `std::is_assignable_v<typename mdspan<SrcElementType, SrcExtents, SrcLayoutPolicy, SrcAccessorPolicy>::reference, typename mdspan<DstElementType, DstExtents, DstLayoutPolicy, DstAccessorPolicy>::reference>`
+  * [1.1]{.pnum} `std::is_assignable_v<typename mdspan<SrcElementType, SrcExtents, SrcLayoutPolicy, SrcAccessorPolicy>::reference, typename mdspan<DstElementType, DstExtents, DstLayoutPolicy, DstAccessorPolicy>::reference>` is `true`.
 
-  * [1.2]{.pnum} `mdspan<SrcElementType, SrcExtents, SrcLayoutPolicy, SrcAccessorPolicy>::rank() == mdspan<DstElementType, DstExtents, DstLayoutPolicy, DstAccessorPolicy>::rank()`
+  * [1.2]{.pnum} `mdspan<SrcElementType, SrcExtents, SrcLayoutPolicy, SrcAccessorPolicy>::rank()` equals `mdspan<DstElementType, DstExtents, DstLayoutPolicy, DstAccessorPolicy>::rank()`.
 
 [2]{.pnum} *Preconditions:*
 
@@ -65,10 +65,10 @@ void copy(ExecutionPolicy&& policy, const mdspan<SrcElementType, SrcExtents, Src
 
 ```c++
 template<class ElementType, class Extents, class LayoutPolicy, class AccessorPolicy, class T>
-void fill(const mdspan<ElementType, Extents, LayoutPolicy, AccessorPolicy> &dst, const T &value)
+void fill(mdspan<ElementType, Extents, LayoutPolicy, AccessorPolicy> dst, const T& value);
 
 template<class ExecutionPolicy, class ElementType, class Extents, class LayoutPolicy, class AccessorPolicy, class T>
-void fill(ExecutionPolicy&& policy, const mdspan<ElementType, Extents, LayoutPolicy, AccessorPolicy> &dst, const T &value)
+void fill(ExecutionPolicy&& policy, mdspan<ElementType, Extents, LayoutPolicy, AccessorPolicy> dst, const T& value);
 ```
 
 [4]{.pnum} *Constraints:* `std::is_assignable_v<typename mdspan<ElementType, Extents, LayoutPolicy, AccessorPolicy>::reference, const T &T>`