Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial GitHub Actions #58

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Initial GitHub Actions #58

merged 5 commits into from
Mar 5, 2024

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented Mar 4, 2024

CPU build/test only so far; cached boost because the builds are so long; separate format check

Closes #57

@streeve streeve requested a review from stvdwtt March 4, 2024 00:38
@streeve streeve self-assigned this Mar 4, 2024
@streeve streeve force-pushed the gha branch 3 times, most recently from 4b1de70 to f3da646 Compare March 4, 2024 00:59
@jeanlucf22 jeanlucf22 force-pushed the gha branch 2 times, most recently from efd643f to def4273 Compare March 4, 2024 18:24
@jeanlucf22
Copy link
Collaborator

Looks like the remaining issue is with catch2.hpp not being formatted correctly? CMakeLists.txt does not include this file in the list of files to format, and so it is in its original format, as downloaded. Does the CI try to format it?

@streeve
Copy link
Collaborator Author

streeve commented Mar 5, 2024

Looks like the remaining issue is with catch2.hpp not being formatted correctly? CMakeLists.txt does not include this file in the list of files to format, and so it is in its original format, as downloaded. Does the CI try to format it?

Should be good - just excluded that one file

@jeanlucf22
Copy link
Collaborator

Thanks @streeve !

@jeanlucf22 jeanlucf22 merged commit 7c315fc into master Mar 5, 2024
3 checks passed
@jeanlucf22 jeanlucf22 deleted the gha branch March 5, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI using GitHub Actions
2 participants