Use enums instead of strings to denote memory space #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronrutherford
approved these changes
Oct 31, 2023
rothpc
approved these changes
Oct 31, 2023
|
After these changes unit tests will need some refactoring. They are patched up and functional now, but not quite straightforward to maintan. |
|
Related issue is #12 |
kswirydo
approved these changes
Oct 31, 2023
pelesh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace strings that are currently used to identify different memory spaces with
enums.enums are now used to select memory space for vector and matrix classes. The options are HOST and DEVICE.This PR does not deal with matrix and vector handlers.