Fix issue with hard-wired CUDA consumer. #34
Conversation
|
Tested this on incline by hand and if I cherry-pick this commit onto |
Thanks! Let me rebase wrt incline-dev and redirect this PR there. |
|
Added a hotfix to cmake.in file and it should be working now. Tested the no gpu/cuda build and it worked for me. |
|
I just tried it at Frontier and the consumer test works like a charm! Thanks @ryandanehy. |
| if(@RESOLVE_USE_CUDA@) | ||
| set(CMAKE_CUDA_COMPILER @CMAKE_CUDA_COMPILER@) | ||
| enable_language(CUDA) | ||
| check_language(CUDA) | ||
| set(CMAKE_CUDA_FLAGS "@CMAKE_CUDA_FLAGS@") | ||
| find_package(CUDAToolkit REQUIRED) | ||
| endif() |
There was a problem hiding this comment.
Perhaps we should have been stricter about this like in Sundials?
This would involve checking for existence of the required cuda targets incase they are already defined #33 (comment)
Either way, HiOp also has this issue, and we won't know the right approach until we add ReSolve into HiOp :)
Fixes #33.