Fix issue with linking workspace to HyKKT. #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksud
approved these changes
Jan 8, 2025
|
Checked on Frontier and on CUDA machine. All tests pass |
shakedregev
added a commit
that referenced
this pull request
Jan 15, 2025
* added new permutation kernels * edited cmake * added Hello world tests * added Hello world tests * resolved conflict * hykkt hello world working, working on linking for permutation * resolved conflict * Ignore files in resolve/hybrid dir. * Remove cpu subdirectory in hykkt dir. * hykkt lib builds. * Fix issues in CMake related to HyKKT build. * resolved conflict * HyKKT permutation test works. * modifications for CUDA * removed extraneous tests * reformatted according to contributing guidelines * fixed straggling old names * stash * fixed capitalization for selectionSort2 * fixed capitalization for selectionSort2 * doesn't add hykkt if not using suitesparse * doesn't add hykkt if not using suitesparse * added namespaces and capitalized enums * fixed naming * function alignment * namespace fixes, const where possible * Fix issue with linking workspace to HyKKT. (#211) * Coding style suggestions (#213) * Coding style suggestions. * added param in/out * Style suggestions for permutation tests. * Some more doxygen formatting. --------- Co-authored-by: shakedregev <[email protected]> * added requested changes * addressed Doxygen comment issues --------- Co-authored-by: Slaven Peles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure a workspace library is linked to HyKKT module in Re::Solve.
Also, if CUDA or HIP are enabled, they can be linked with HyKKT module. The module may not use any of those backends, but it can be linked to them.