Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FindKLU with FindSuiteSparse #206

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Replace FindKLU with FindSuiteSparse #206

merged 2 commits into from
Dec 18, 2024

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Dec 18, 2024

Replaced FindKLU.cmake file with a more general FindSuiteSparse.cmake. The new finding function now looks for AMD, COLAMD and KLU libraries. This will be needed for HyKKT integration (currently in works by @shakedregev) as HyKKT links directly to AMD but not KLU. The new finding function can be easily extended to add other libraries from SuiteSparse (I suspect we'll need CHOLMOD soon).

Also changed in this PR -- all external dependencies are off by default. User needs to enable them explicitly now.

This PR is mainly reusing @cameronrutherford's work in GridKit.

Replaced FindKLU with FindSuiteSparse, now looking for AMD, COLAMD and KLU libs.
@pelesh pelesh added enhancement New feature or request cmake labels Dec 18, 2024
@pelesh pelesh self-assigned this Dec 18, 2024
Copy link
Collaborator

@shakedregev shakedregev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments on the code, I ran it successfully.

@pelesh pelesh merged commit 0d9baf8 into develop Dec 18, 2024
4 checks passed
@shakedregev
Copy link
Collaborator

shakedregev commented Dec 18, 2024

I just now noticed that make test_install actually fails

/home/szb/ReSolve/install/include/resolve/LinSolverDirectKLU.hpp:3:10: fatal error: klu.h: No such file or directory
    3 | #include "klu.h"
      |          ^~~~~~~
compilation terminated.
gmake[6]: *** [CMakeFiles/consume.exe.dir/build.make:76: CMakeFiles/consume.exe.dir/consumer.cpp.o] Error 1
gmake[5]: *** [CMakeFiles/Makefile2:83: CMakeFiles/consume.exe.dir/all] Error 2
gmake[4]: *** [Makefile:101: all] Error 2
make[3]: *** [examples/CMakeFiles/test_install.dir/build.make:70: examples/CMakeFiles/test_install] Error 2
make[2]: *** [CMakeFiles/Makefile2:732: examples/CMakeFiles/test_install.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:739: examples/CMakeFiles/test_install.dir/rule] Error 2
make: *** [Makefile:322: test_install] Error 2`

@pelesh
Copy link
Collaborator Author

pelesh commented Dec 18, 2024

I just now noticed that make test_install actually fails

I can't reproduce this issue and installed ReSolveTargets.cmake looks correct to me. @shakedregev, could you please create an issue and post error output you are getting and the content of the ReSolveTargets.cmake you get installed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants