Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of coo2csr conversion #174

Closed
wants to merge 3 commits into from
Closed

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Jul 5, 2024

The new implementation of coo2csr has complexity $O(NNZ\log(NNZ))$. It handles unordered COO with duplicates. More testing is needed.

@pelesh pelesh force-pushed the matrix-conversion-test-dev branch from 802c6fd to ee813ce Compare September 12, 2024 20:52
@pelesh pelesh self-assigned this Sep 12, 2024
@superwhiskers
Copy link
Collaborator

my only comment to make here would be that there's #175 which i can open a pull request to the branch of to add in the fixes for the conversion code i developed while fixing and making #178

@pelesh
Copy link
Collaborator Author

pelesh commented Sep 13, 2024

my only comment to make here would be that there's #175 which i can open a pull request to the branch of to add in the fixes for the conversion code i developed while fixing and making #178

Tests fail in #175 so it is not a ready-to-merge solution. I need to address #176 before we can implement a sustainable solution.

@pelesh pelesh closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants