Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make test_install to github tests. #170

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Jun 21, 2024

Running ctest triggers testing the build. Running make test_install starts installation tests. The latter will verify if all runtime paths are set correctly.

@pelesh pelesh self-assigned this Jun 21, 2024
@pelesh pelesh requested a review from cameronrutherford June 21, 2024 14:29
@pelesh pelesh marked this pull request as ready for review June 21, 2024 14:29
Copy link
Collaborator

@cameronrutherford cameronrutherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI logs look good! Thanks for adding this

@cameronrutherford
Copy link
Collaborator

I have a few ideas to speed up the spack pipelines:

  1. only re-build base image if it doesn't exist
  2. cache a spack.lock so we don't have to concretize

1 is definitely a no brainer, and should be done.

2 is a little more complicated. You would need to remember to remove that file when you update the spack submodule. Additionally we would have to maintain a lock file for each build in the matrix.

@pelesh pelesh merged commit d7bc2b3 into spack-build-add-test Jun 21, 2024
4 checks passed
pelesh added a commit that referenced this pull request Jun 21, 2024
* Fix spack test stage..

* Add `--keep-stage` to spack install to keep build dir...

* Avoid using cache in spack install...

* Install dependencies from cache, but not resolve.

* Add ~/+lusol builds.

* Add make test_install to github tests. (#170)

* Disable Lusol by default.

* Enable full build without LUSOL.

---------

Co-authored-by: pelesh <[email protected]>
@pelesh pelesh deleted the spack-build-add-test-install branch June 26, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants