Fix compiler warnings #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswirydo
approved these changes
Feb 16, 2024
| @@ -106,6 +106,7 @@ namespace ReSolve | |||
| } | |||
| } | |||
| } | |||
| // TODO: What is the purpose of nnzL and nnzU if they are not used after this? | |||
There was a problem hiding this comment.
ups thats a bug - now that I have nnzL and nnzU, they should be used while allocating L and U!!! will fix after this is approved.
| @@ -165,7 +165,7 @@ namespace ReSolve { | |||
| a->update(x->getVectorData(i, ms), ms, memory::HOST); | |||
| b->update(x->getVectorData(j, ms), ms, memory::HOST); | |||
| ip = handler->dot(a, b, memory::HOST); | |||
| if ( (i != j) && (abs(ip) > 1e-14)) { | |||
| if ( (i != j) && !isEqual(ip, 0.0)) { | |||
There was a problem hiding this comment.
if you use isEqual here, GramSchmidt test fails on deception (on CPU).
There was a problem hiding this comment.
although, there was one other bug that might had been causing this so I take this back (the bug had been fixed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed most of compiler workings in #137.