Fix bug when data/values ownership is incorrectly assigned. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelesh
force-pushed
the
system-solver-update-dev
branch
from
9d489e1 to
86e232a
Compare
author Slaven Peles <[email protected]> 1702759728 -0500 committer Slaven Peles <[email protected]> 1702871403 -0500 parent ec87c03b1f29997940e23f24a7b81230d8aaadd1 author Slaven Peles <[email protected]> 1702759728 -0500 committer Slaven Peles <[email protected]> 1702871274 -0500 Add more diagnostics to Csr matrix.
pelesh
force-pushed
the
linalg-ownership-fix
branch
from
257ef6d to
7fa6682
Compare
pelesh
added a commit
that referenced
this pull request
Dec 20, 2023
* Fix bug when data/values ownership is incorrectly assigned. * parent ec87c03b1f29997940e23f24a7b81230d8aaadd1 author Slaven Peles <[email protected]> 1702759728 -0500 committer Slaven Peles <[email protected]> 1702871403 -0500 parent ec87c03b1f29997940e23f24a7b81230d8aaadd1 author Slaven Peles <[email protected]> 1702759728 -0500 committer Slaven Peles <[email protected]> 1702871274 -0500 Add more diagnostics to Csr matrix. * Addressing comments in the PR. * Fix broken build, add logger to Csc and Coo classes.
pelesh
added a commit
that referenced
this pull request
Dec 20, 2023
* Refactor residual norm getter in SystemSolver. * Implement and test NSR computation in SystemSolver. * Have iterative refinement inside the solve call. * System solver example that works with CUDA and HIP. * Fix cmake presets for Deception. * Fix SystemSolver running GLU test. * Use memspace as parameter consistently in FGMRES classes. (#125) * Fix bug when data/values ownership is incorrectly assigned. (#124) * Fix broken CPU build, add logger to Csc and Coo classes. * Have fgmres and gs set memory space at runtime based on vector handler. * Randomized solver called through SystemSolver class (#128) * Support for iterative methods in SystemSolver. * Working example of a randomized solver. * Use more consistent naming scheme for functionality tests. * Fix issue with building SystemSolver on CPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123