Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU vector handler functions #113

Merged
merged 3 commits into from
Dec 14, 2023
Merged

CPU vector handler functions #113

merged 3 commits into from
Dec 14, 2023

Conversation

kswirydo
Copy link
Collaborator

@kswirydo kswirydo commented Dec 14, 2023 •
edited
Loading

Added:

  • gemv
  • mass axpy
  • mass dot product with 2 vectors
  • tests in cpu testing suite

Fixed:

  • subtle bug in setToConst for multivectors

@kswirydo kswirydo requested a review from pelesh December 14, 2023 06:01
pelesh
pelesh approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have all these functions return int instead of returning void?

In any case, good to merge with some minor fixes.

resolve/vector/Vector.cpp Outdated Show resolved Hide resolved
resolve/vector/VectorHandlerCpu.cpp Outdated Show resolved Hide resolved
@pelesh pelesh merged commit e37bac1 into develop Dec 14, 2023
@pelesh pelesh deleted the cpu-vector-handler branch December 21, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelesh pelesh pelesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kswirydo @pelesh