-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK compliance of adding api version #111
Conversation
I included a test within make test that runs the function so the pipelines should be doing tests of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are preparing alpha release, how will function int ResolveVersionGetVersion(int *, int *, int *);
handle something like 1.0.0-alpha1
? Perhaps we could add version label to the versioning?
This function was designed to make our lives potentially easier in future releases. I imagined a scenario in which we would want to change the cmake based on whether the version was less than or greater than a particularly major or minor release. In this situation the alpha part doesn't really matter in my opinion because any major change that would utlize this function would result in a change in major, minor or patch number right? And we always have the ReSolveVersionGetVersionstr function to get the whole version. |
How are we feeling about this pr? |
I just added a couple of touches and managed to break the build :). I think if tests pass, we can merge this. |
Add version.cpp function that grabs the version of resolve in order to satisfy SDK compliance. In reference to #2