Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK compliance of adding api version #111

Merged
merged 5 commits into from
Dec 14, 2023
Merged

SDK compliance of adding api version #111

merged 5 commits into from
Dec 14, 2023

Conversation

ryandanehy
Copy link
Collaborator

Add version.cpp function that grabs the version of resolve in order to satisfy SDK compliance. In reference to #2

@ryandanehy ryandanehy requested a review from pelesh December 12, 2023 22:14
@ryandanehy
Copy link
Collaborator Author

I included a test within make test that runs the function so the pipelines should be doing tests of it.

@ryandanehy ryandanehy self-assigned this Dec 12, 2023
@pelesh pelesh added the xSDK label Dec 12, 2023
@pelesh pelesh added this to the xSDK milestone Dec 12, 2023
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are preparing alpha release, how will function int ResolveVersionGetVersion(int *, int *, int *); handle something like 1.0.0-alpha1? Perhaps we could add version label to the versioning?

resolve/utilities/version.hpp Outdated Show resolved Hide resolved
resolve/utilities/version.hpp Outdated Show resolved Hide resolved
tests/functionality/testversion.cpp Outdated Show resolved Hide resolved
@ryandanehy
Copy link
Collaborator Author

Since we are preparing alpha release, how will function int ResolveVersionGetVersion(int *, int *, int *); handle something like 1.0.0-alpha1? Perhaps we could add version label to the versioning?

This function was designed to make our lives potentially easier in future releases. I imagined a scenario in which we would want to change the cmake based on whether the version was less than or greater than a particularly major or minor release. In this situation the alpha part doesn't really matter in my opinion because any major change that would utlize this function would result in a change in major, minor or patch number right? And we always have the ReSolveVersionGetVersionstr function to get the whole version.

@ryandanehy
Copy link
Collaborator Author

How are we feeling about this pr?

@pelesh
Copy link
Collaborator

pelesh commented Dec 14, 2023

How are we feeling about this pr?

I just added a couple of touches and managed to break the build :). I think if tests pass, we can merge this.

@pelesh pelesh merged commit d3f8532 into develop Dec 14, 2023
5 of 6 checks passed
@pelesh pelesh deleted the version branch December 21, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants