Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect GPU kernels with appropriate nemespaces. #107

Merged
merged 30 commits into from
Dec 12, 2023
Merged

Protect GPU kernels with appropriate nemespaces. #107

merged 30 commits into from
Dec 12, 2023

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Dec 9, 2023

In this PR:

  • Put GPU kernels in appropriate namespaces.
  • Add templates for Doxygen documentation to kernel functions (partially documented).
  • Remove unused hipVectorKernels.h and cudaVectorKernels.h files.

Closes #106.

@pelesh pelesh added documentation Improvements or additions to documentation enhancement New feature or request hip cuda labels Dec 9, 2023
@pelesh pelesh added this to the First Release milestone Dec 9, 2023
@pelesh pelesh requested a review from kswirydo December 9, 2023 03:29
@pelesh pelesh self-assigned this Dec 9, 2023
kswirydo
kswirydo reviewed Dec 11, 2023
View reviewed changes
resolve/cuda/cudaKernels.cu Outdated Show resolved Hide resolved
resolve/cuda/cudaKernels.cu Outdated Show resolved Hide resolved
resolve/cuda/cudaKernels.cu Outdated Show resolved Hide resolved
resolve/cuda/cudaKernels.cu Outdated Show resolved Hide resolved
resolve/cuda/cudaKernels.cu Outdated Show resolved Hide resolved
resolve/hip/hipKernels.hip Outdated Show resolved Hide resolved
resolve/hip/hipKernels.hip Outdated Show resolved Hide resolved
resolve/hip/hipKernels.hip Outdated Show resolved Hide resolved
resolve/hip/hipKernels.hip Outdated Show resolved Hide resolved
resolve/hip/hipKernels.hip Outdated Show resolved Hide resolved
pelesh and others added 21 commits December 11, 2023 15:05
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
2e4dcef 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
ab7db37 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
8d981b9 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
a1c9377 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
5957a3d 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
9314c1d 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/hip/hipKernels.hip
950926f 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/hip/hipKernels.hip
9720d3a 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/hip/hipKernels.hip
0c3148c 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/hip/hipKernels.hip
883173d 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/hip/hipKernels.hip
28383cb 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
c9447dd 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/hip/hipKernels.hip
5c01fd0 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
c10b484 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
43fb60c 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
b502b43 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
e5a40d6 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
a3f3c67 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
3dc3a02 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
538fc74 
Co-authored-by: kswirydo <[email protected]>
@pelesh @kswirydo
[skip ci] Update resolve/cuda/cudaKernels.cu
906fed6 
Co-authored-by: kswirydo <[email protected]>
pelesh and others added 8 commits December 11, 2023 15:16
@pelesh pelesh merged commit a697d07 into develop Dec 12, 2023
6 checks passed
@pelesh pelesh deleted the gpu-kernels-dev branch February 21, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kswirydo kswirydo kswirydo left review comments

Assignees

@pelesh pelesh

Labels
cuda documentation Improvements or additions to documentation enhancement New feature or request hip
Projects
None yet
Milestone
First Release
Development

Successfully merging this pull request may close these issues.

Protect GPU kernels with appropriate namespace(s)
2 participants
@pelesh @kswirydo