Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Csr constructor that takes Coo as the argument #100

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Create Csr constructor that takes Coo as the argument #100

merged 4 commits into from
Dec 6, 2023

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Dec 5, 2023

Closes #98

@pelesh pelesh added the enhancement New feature or request label Dec 5, 2023
@pelesh pelesh requested a review from kswirydo December 5, 2023 17:43
@pelesh pelesh self-assigned this Dec 5, 2023
@pelesh pelesh marked this pull request as draft December 5, 2023 17:52
kswirydo
kswirydo approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@kswirydo kswirydo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation: leave coo2csr in matrix_handler as well (at least for now).

resolve/matrix/Csr.cpp
#endif
this->setNnz(nnz_no_duplicates);
this->updateData(csr_ia, csr_ja, csr_a, memory::HOST, memspace);
// if (memspace == "cpu"){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider removing commented out stuff.

@pelesh pelesh marked this pull request as ready for review December 6, 2023 03:43
@pelesh pelesh merged commit 3456241 into develop Dec 6, 2023
8 checks passed
@pelesh pelesh deleted the coo2csr-ctor-dev branch December 11, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kswirydo kswirydo kswirydo approved these changes

Assignees

@pelesh pelesh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Csr matrix constructor that takes Coo matrix as the input
2 participants
@pelesh @kswirydo