minor formatting changes, removed comment

ORNL · Oct 17, 2024 · a6d8414 · a6d8414
1 parent a988879
commit a6d8414
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/tests/functionality/CMakeLists.txt b/tests/functionality/CMakeLists.txt
@@ -7,8 +7,8 @@
 ]]
 
 # Create functionality test helper
-add_library( FunctionalityTestHelper SHARED FunctionalityTestHelper.cpp )
-target_link_libraries( FunctionalityTestHelper PRIVATE ReSolve )
+add_library(FunctionalityTestHelper SHARED FunctionalityTestHelper.cpp)
+target_link_libraries(FunctionalityTestHelper PRIVATE ReSolve)
 
 # Build basic version test
 add_executable(version.exe testVersion.cpp) 
@@ -42,7 +42,7 @@ if(RESOLVE_USE_CUDA)
 
     # System solver test with cusolver rf and iterative refinement
     add_executable(sys_refactor_cuda_test.exe testSysRefactor.cpp)
-    target_link_libraries(sys_refactor_cuda_test.exe PRIVATE ReSolve FunctionalityTestHelper )
+    target_link_libraries(sys_refactor_cuda_test.exe PRIVATE ReSolve FunctionalityTestHelper)
 
     # Build KLU+GLU test
     add_executable(klu_glu_test.exe testKLU_GLU.cpp)

diff --git a/tests/functionality/FunctionalityTestHelper.cpp b/tests/functionality/FunctionalityTestHelper.cpp
@@ -10,13 +10,13 @@
 #include <resolve/matrix/Csc.hpp>
 #include <resolve/matrix/MatrixHandler.hpp>
 #include <resolve/vector/VectorHandler.hpp>
-#if defined RESOLVE_USE_KLU
-#include <resolve/LinSolverDirectKLU.hpp>
-#endif
 #include "resolve/Common.hpp"
 #include <resolve/LinSolverIterativeFGMRES.hpp>
 #include <resolve/workspace/LinAlgWorkspace.hpp>
 #include <resolve/SystemSolver.hpp>
+#if defined RESOLVE_USE_KLU
+#include <resolve/LinSolverDirectKLU.hpp>
+#endif
 #if defined (RESOLVE_USE_CUDA)
 #include <resolve/LinSolverDirectCuSolverRf.hpp>
   using workspace_type = ReSolve::LinAlgWorkspaceCUDA;

diff --git a/tests/functionality/testSysRefactor.cpp b/tests/functionality/testSysRefactor.cpp
@@ -60,11 +60,6 @@ int main(int argc, char *argv[])
 
   workspace.initializeHandles();
 
-  // Create linear algebra handlers
-
-  ReSolve::MatrixHandler matrix_handler(&workspace);
-  ReSolve::VectorHandler vector_handler(&workspace);
-
   // Create system solver
   ReSolve::SystemSolver solver(&workspace);
 
@@ -141,6 +136,7 @@ int main(int argc, char *argv[])
   status = solver.solve(vec_rhs, vec_x);
   error_sum += status;
 
+  // larger tolerance than default 1e-17 because iterative refinement is not applied here
   ReSolve::tests::FunctionalityTestHelper testhelper( 1e-12 );
 
   error_sum +=