Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IDA Interface Final Copy #37

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Fixed IDA Interface Final Copy #37

merged 4 commits into from
Dec 18, 2024

Conversation

reid-g
Copy link
Collaborator

@reid-g reid-g commented Dec 17, 2024

Fixed the Scale Microgrid problem errors. Turned out to be a final copy missing.

ODE keys are perform better than DAE keys currently.

@reid-g reid-g requested a review from pelesh December 17, 2024 01:20
@reid-g reid-g added the bug Something isn't working label Dec 17, 2024
@reid-g reid-g self-assigned this Dec 17, 2024
@reid-g reid-g linked an issue Dec 17, 2024 that may be closed by this pull request
@pelesh pelesh changed the base branch from develop to nicholson/buildsystem December 17, 2024 02:08
@pelesh pelesh changed the base branch from nicholson/buildsystem to develop December 17, 2024 02:09
@pelesh pelesh mentioned this pull request Dec 17, 2024
@reid-g reid-g force-pushed the scale-microgrid-copy-fix branch from 4881562 to c4eac32 Compare December 18, 2024 19:33
@reid-g reid-g requested a review from pelesh December 18, 2024 20:27
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass in github actions and on my local machine. Bug fixes appropriate.

@pelesh pelesh merged commit 6b15e29 into develop Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale Microgrid Test Error
2 participants