Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples section labels #85

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

pabloseleson
Copy link
Collaborator

Added section labels to examples for clarity and made sections order consistent between examples.

@pabloseleson pabloseleson requested a review from streeve March 14, 2024 14:49
Copy link
Collaborator

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, needs a few changes (which mostly apply to all 3, but I only commented in crack branching)

examples/crack_branching.cpp Outdated Show resolved Hide resolved
examples/crack_branching.cpp Outdated Show resolved Hide resolved
examples/crack_branching.cpp Outdated Show resolved Hide resolved
examples/crack_branching.cpp Outdated Show resolved Hide resolved
examples/elastic_wave.cpp Show resolved Hide resolved
@pabloseleson pabloseleson requested a review from streeve March 19, 2024 14:35
@streeve streeve force-pushed the examples_section_labels branch from 8b5d641 to 895f2b5 Compare March 19, 2024 15:32
@streeve streeve merged commit ee240e0 into ORNL:main Mar 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants