Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input file #44

Merged
merged 20 commits into from
Nov 16, 2023
Merged

Input file #44

merged 20 commits into from
Nov 16, 2023

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented Aug 14, 2023 •
edited
Loading

Add json dependency; convert Inputs class to use json; and convert example system size, time, material properties, and delta inputs to json

Closes #5

@streeve streeve added the enhancement New feature or request label Aug 14, 2023
@streeve streeve requested a review from pabloseleson August 14, 2023 15:27
@streeve streeve self-assigned this Aug 14, 2023
@streeve streeve force-pushed the input_file branch 2 times, most recently from a06a4c6 to f71aad3 Compare August 14, 2023 15:51
@streeve streeve force-pushed the input_file branch 3 times, most recently from 2338e7a to 8fa835a Compare October 4, 2023 17:58
@streeve streeve mentioned this pull request Oct 5, 2023
Draft
@streeve
Copy link
Collaborator Author

streeve commented Nov 10, 2023

@pabloseleson what's the status here?

streeve
streeve commented Nov 15, 2023
View reviewed changes
examples/crack_branching.cpp Outdated Show resolved Hide resolved
examples/inputs/elastic_wave.json Show resolved Hide resolved
src/CabanaPD_Input.hpp Show resolved Hide resolved
src/CabanaPD_Solver.hpp Outdated Show resolved Hide resolved
pabloseleson
pabloseleson approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@pabloseleson pabloseleson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run the three examples and they seem OK.

@streeve streeve merged commit 00d2144 into ORNL:main Nov 16, 2023
14 checks passed
@streeve streeve deleted the input_file branch November 16, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloseleson pabloseleson pabloseleson approved these changes

Assignees

@streeve streeve

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add input files
2 participants
@streeve @pabloseleson