Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add particle property to store current positions #32

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

pabloseleson
Copy link
Collaborator

No description provided.

@pabloseleson pabloseleson requested a review from streeve July 21, 2023 20:46
Copy link
Collaborator

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option to use reference/current needs to be added the solver/inputs

src/CabanaPD_Particles.hpp Outdated Show resolved Hide resolved
src/CabanaPD_Particles.hpp Outdated Show resolved Hide resolved
src/CabanaPD_Particles.hpp Outdated Show resolved Hide resolved
src/CabanaPD_Particles.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing Particle member function to sum x+u into y

@streeve streeve force-pushed the current_positions branch from f6243ff to 944a20e Compare August 29, 2023 13:36
@streeve
Copy link
Collaborator

streeve commented Aug 29, 2023

@pabloseleson ready for testing

@streeve
Copy link
Collaborator

streeve commented Sep 28, 2023

@pabloseleson ready for testing again

@streeve streeve mentioned this pull request Sep 29, 2023
@streeve streeve force-pushed the current_positions branch from 8c26f83 to 6025939 Compare October 3, 2023 17:29
@streeve
Copy link
Collaborator

streeve commented Oct 3, 2023

@pabloseleson this should be fixed now

@streeve streeve force-pushed the current_positions branch from 6025939 to 2af18d7 Compare October 4, 2023 15:23
@streeve streeve force-pushed the current_positions branch from 2af18d7 to fc61746 Compare October 4, 2023 15:34
@streeve streeve merged commit 3dbc754 into ORNL:main Oct 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants