Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEM Force Model #158

Merged
merged 3 commits into from
Dec 20, 2024
Merged

DEM Force Model #158

merged 3 commits into from
Dec 20, 2024

Conversation

abisner
Copy link
Collaborator

@abisner abisner commented Dec 9, 2024

This PR adds the Hertzian force model for DEM simulations.

@streeve streeve self-requested a review December 17, 2024 19:29
streeve
streeve reviewed Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add a line calculating the restitution as a check, I'll convert to a unit test

src/force/CabanaPD_Force_HertzianContact.hpp Outdated Show resolved Hide resolved
src/force/CabanaPD_Force_HertzianContact.hpp Outdated Show resolved Hide resolved
@streeve streeve changed the title (Draft) DEM Force Model DEM Force Model Dec 18, 2024
streeve
streeve approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abisner I will merge after rebasing unless you have other changes

abisner and others added 3 commits December 20, 2024 07:49
@streeve streeve merged commit a92de7b into ORNL:main Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streeve streeve streeve approved these changes

Assignees

@abisner abisner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abisner @streeve