-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dimension and consistency checks for size / corners and num_cells / dx #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pabloseleson can you test a couple examples to make sure this is working?
@pabloseleson this now only addresses your requested changes since it was needed in #155 |
Here are 3 tests with outputs: Test 1: Inputs:
Outputs: system_size : (100.0 , 150.0 , 300.0) "m" Test 2: Inputs:
Outputs: system_size : (100.0 , 150.0 , 300.0) "m" Test 3: Inputs:
Outputs: system_size : (100.0 , 150.0 , 300.0) "m" Output code (in CabanaPD_Input.hpp at the end of setupSize)
|
Tests for inconsistencies: Test i Inputs:
Output Units for dx do not match system units. Test ii Inputs:
Output: Units for low_corner and high_corner do not match. Test iii Inputs:
Output: Units for dx do not match system units. |
Tests for inconsistent dimensions Test a Inputs:
Output: CabanaPD requires 3d (dx). Test b Inputs:
Output: CabanaPD requires 3d (system_size). Test c Inputs:
Output: CabanaPD requires 3d (low_corner). Test d Inputs:
Output: CabanaPD requires 3d (high_corner). Test e Inputs:
Output: CabanaPD requires 3d (num_cells). Test f Inputs:
Output: CabanaPD requires 3d (system_size). |
Also adds errors if neither are available