Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added critical time step for heat transfer #152

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Added critical time step for heat transfer #152

merged 1 commit into from
Jan 3, 2025

Conversation

pabloseleson
Copy link
Collaborator

@pabloseleson pabloseleson commented Nov 22, 2024 •
edited by streeve
Loading

No description provided.

@pabloseleson pabloseleson requested a review from streeve November 22, 2024 17:19
@streeve streeve changed the title Added critical time step for heat transfer (preliminary) Added critical time step for heat transfer Nov 22, 2024
@streeve streeve marked this pull request as draft November 22, 2024 20:07
streeve
streeve requested changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should combine these in one function, but in a new function separate from the Inputs constructor since we need the force model details to determine whether we're running heat transfer or not

@pabloseleson
Copy link
Collaborator Author

Sure, could you please make the change?

@pabloseleson
Copy link
Collaborator Author

We need to account for "thermal_subcycle_steps>1" for the critical time step calculation for heat transfer.

@streeve streeve marked this pull request as ready for review December 5, 2024 16:55
@streeve streeve force-pushed the critical_time_step_heat_transfer branch from 72966e2 to b7c9340 Compare December 17, 2024 21:02
pabloseleson
pabloseleson commented Dec 18, 2024
View reviewed changes
src/CabanaPD_Input.hpp Outdated Show resolved Hide resolved
pabloseleson
pabloseleson commented Dec 18, 2024
View reviewed changes
src/CabanaPD_Input.hpp Outdated Show resolved Hide resolved
pabloseleson
pabloseleson commented Jan 2, 2025
View reviewed changes
src/CabanaPD_Input.hpp Outdated Show resolved Hide resolved
@streeve streeve force-pushed the critical_time_step_heat_transfer branch from a9b72fd to dc636a8 Compare January 3, 2025 15:46
@streeve streeve force-pushed the critical_time_step_heat_transfer branch from ab6e65b to a8c788b Compare January 3, 2025 19:11
pabloseleson
pabloseleson commented Jan 3, 2025
View reviewed changes
Copy link
Collaborator Author

@pabloseleson pabloseleson left a comment •
edited by streeve
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the example is running. It seems ready.

@streeve streeve merged commit fc0e697 into ORNL:main Jan 3, 2025
14 checks passed
@streeve streeve deleted the critical_time_step_heat_transfer branch January 3, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streeve streeve streeve approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pabloseleson @streeve