Enable multi-material #119
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streeve
force-pushed
the
interaction_lists
branch
2 times, most recently
from
57d4112 to
45d0c32
Compare
streeve
force-pushed
the
interaction_lists
branch
from
3f6efe0 to
315f5cb
Compare
simplifies template parameters with single-species tag
streeve
force-pushed
the
interaction_lists
branch
3 times, most recently
from
332546b to
8686675
Compare
streeve
force-pushed
the
interaction_lists
branch
from
8686675 to
c089abf
Compare
streeve
commented
Aug 27, 2024
|
|
||
| KOKKOS_INLINE_FUNCTION void operator()( const int i ) const | ||
| { | ||
| c( i, i ) = micromodulus( i ); |
There was a problem hiding this comment.
Should move this to a separate loop
| exec_space(), low_corner, high_corner, num_cells, halo_width ); | ||
|
|
||
| std::array<double, 2> same_d = { delta, delta }; |
There was a problem hiding this comment.
We shouldn't modify the Kalthoff Winkler example. If this is just for testing, we need to create a new example.
There was a problem hiding this comment.
I agree, I will remove when you push a new example
| "density" : {"value": 3980, "unit": "kg/m^3"}, | ||
| "elastic_modulus" : {"value": 370e+9, "unit": "Pa"}, | ||
| "elastic_modulus" : {"value": [370e+9, 100e+9, 10e+9], "unit": "Pa", "note": "11, 22, 12"}, |
There was a problem hiding this comment.
Why do we have 3 values here? I believe we only need for a bimaterial the elastic modulus of material 1 and material 2.
There was a problem hiding this comment.
I moved this to draft. But until we have a bi-material example, I need places to test things are working
| @@ -82,7 +82,8 @@ void thermalDeformationExample( const std::string filename ) | |||
| // Force model | |||
| // ==================================================== | |||
| auto force_model = CabanaPD::createForceModel( | |||
| model_type{}, CabanaPD::Elastic{}, *particles, delta, K, alpha, temp0 ); | |||
| model_type{}, CabanaPD::Elastic{}, CabanaPD::TemperatureDependent{}, | |||
There was a problem hiding this comment.
This does not seem related to bimaterial models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type lists to new force models, with averaged properties for cross terms
Closes #109