Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the operation duneB_.mmv(x, resWell) in recoverSolutionWell into its two parts #5741

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lisajulia
Copy link
Contributor

This is needed to later add communication for the multiplication with the matrix duneB_, since here we go from cells to segments, and everything concerning segments is stored globally.

@lisajulia lisajulia force-pushed the feature/ms-wells-split-mmv-in-recoverSolutionWell branch from 51e0918 to 713cd4d Compare November 18, 2024 08:36
@lisajulia lisajulia marked this pull request as draft November 18, 2024 08:37
@lisajulia
Copy link
Contributor Author

jenkins build this failure_report please

@lisajulia
Copy link
Contributor Author

lisajulia commented Nov 18, 2024

6 failing tests

Problems at least at:

  • 01_9_3d_grpctl_msw_model2 WGIGR:INJ2
  • 01_9_3d_grpctl_msw_model2 WGIP:INJ2
  • 01_9_3d_grpctl_msw_model2 WWPR:PROD3
  • 01_9_3d_grpctl_msw_model2 WBHP:PROD3

This might be related to the time step change as well, like here: #5738 (comment)

No visible deviations at:

  • 02_9_3e_grpctl_msw_model2
  • 03_9_4d_grpctl_msw_model2
  • 04_9_4c_grpctl_msw_model2
  • 05_0a3_grpctl_msw_model2
  • 06_wsegvalv

@GitPaean
Copy link
Member

For the one has obvious deviation, you can check whether there is deviation if you use small time step, for example, maximum 1 day time step. If with small time step, it has a good match, then to a big extend, we can think it is related to the different time step lengths.

lisajulia added a commit to lisajulia/opm-tests that referenced this pull request Nov 18, 2024
…019 to better compare the test compareECLFiles_flow+9_3D_GINJ_GAS_MAX_EXPORT_MSW for OPM/opm-simulators#5741
@lisajulia
Copy link
Contributor Author

lisajulia commented Nov 18, 2024

jenkins build this opm-tests=1248 failure_report please

@GitPaean
Copy link
Member

@akva2 @hnil do you understand the reasoning here?

@GitPaean GitPaean requested a review from akva2 November 18, 2024 14:13
@GitPaean
Copy link
Member

It is good to show this change might cause regressions, but I think this type of change can go in with the main PR together (including the PR #5738) so the picture is more clear.

@lisajulia
Copy link
Contributor Author

lisajulia commented Nov 19, 2024

It is good to show this change might cause regressions, but I think this type of change can go in with the main PR together (including the PR #5738) so the picture is more clear.

Yes, yet the PR #5680 is for the assembly and I will open another one for solving briefly.

@lisajulia
Copy link
Contributor Author

It is good to show this change might cause regressions, but I think this type of change can go in with the main PR together (including the PR #5738) so the picture is more clear.

Yes, yet the PR #5680 is for the assembly and I will open another one for solving briefly.

This is the one for solving: #5746

…o its two parts

This is needed to later add communication for the multiplication with the matrix duneB_, since here we go from cells to segments, and everything concerning segments is stored globally.
@lisajulia lisajulia force-pushed the feature/ms-wells-split-mmv-in-recoverSolutionWell branch from 713cd4d to 118ccc6 Compare November 22, 2024 07:29
@lisajulia
Copy link
Contributor Author

jenkins build this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants