-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx gha #5349
Sphinx gha #5349
Conversation
jenkins buil this opm-common=4018 please |
I'm currently still working on these two issues:
|
db4d77b
to
db2ddc8
Compare
For the first issue:
For the second issue: The methods are grouped now, but there is still room for improvement |
659dc03
to
5c96cc2
Compare
edbd673
to
8676a23
Compare
Almost done, now I still need to change the Poetry build scripts to take the docstrings_common.json from here and not trigger a commit in opm-simulators. Current state: |
d3ea6c9
to
1f76daa
Compare
jenkins build this please |
692e881
to
50c8430
Compare
jenkins build this opm-common=4018 please |
1 similar comment
jenkins build this opm-common=4018 please |
@hakonhagland and @blattms this is also ready for review, finally! |
This looks good to me. Great that you managed to use GitHub actions in opm-common to trigger the sphinx build workflow in opm-simulators, hope this can be activated and tested in practice soon 😄 |
jenkins build this please |
d95a180
to
29e6506
Compare
A rebuild of the documentation is also triggered when the file docstrings_common.json is updated in opm-common
…not for any open PR
…ne, such that all steps can run through and this is not diagnosed as a failure
81eaf4a
to
8260f5a
Compare
… do not directly come from github
Based on #5243, which should be merged first.
Furthermore includes: