Subdivision for mixed bases #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akva2
reviewed
Jan 19, 2017
| @@ -115,6 +115,8 @@ class ASMs2D : public ASMstruct, public ASM2D | |||
| //! \brief Returns the spline curve representing a boundary of this patch. | |||
| //! \param[in] dir Parameter direction defining which boundary to return | |||
| virtual Go::SplineCurve* getBoundary(int dir, int = 1); | |||
| //! \brief Returns the number of bases. | |||
| virtual size_t getNoBasis() const { return 1; } | |||
akva2
reviewed
Jan 19, 2017
src/ASM/ASMs2D.C
Outdated
| int n1, n2; | ||
| if (!neighbor.getSize(n1,n2,basis)) return false; | ||
| std::cout << "\tmaster coords:"; | ||
| for (int i=1; i<=n1; ++i) |
There was a problem hiding this comment.
mest en fyi. #include "Vec3Oper.h" ogo du kan printe en vec3.
akva2
reviewed
Jan 19, 2017
src/ASM/ASMbase.h
Outdated
| @@ -165,6 +165,8 @@ class ASMbase | |||
| virtual unsigned char getNoFields(int b = 0) const { return b > 1 ? 0 : nf; } | |||
| //! \brief Returns the number of Lagrange multipliers per node. | |||
| unsigned char getNoLagPerNode() const { return nLag; } | |||
| //! \brief Returns the number of bases. | |||
| virtual size_t getNoBasis() const { return 1; } | |||
There was a problem hiding this comment.
we do not need another one! https://github.com/OPM/IFEM/blob/master/src/ASM/ASMbase.h#L235
timovanopstal
force-pushed
the
mixsub
branch
5 times, most recently
from
c0cc0f1
to
b0a073e
Compare
timovanopstal
force-pushed
the
mixsub
branch
3 times, most recently
from
ec5d58e
to
ee95e49
Compare
timovanopstal
force-pushed
the
mixsub
branch
from
aa56dcb
to
ad7925c
Compare
timovanopstal
force-pushed
the
mixsub
branch
from
a40a851
to
150484d
Compare
akva2
force-pushed
the
master
branch
4 times, most recently
from
10b3603
to
981f187
Compare
akva2
force-pushed
the
master
branch
2 times, most recently
from
71afb42
to
b4ac149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the merged #83 to mixed bases.
Changes are more extensive than anticipated: I'll probably have to work in ASMmxBase::establishBases() too.