Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: removing single valued feature #15

Merged
merged 3 commits into from
Apr 15, 2024
Merged

feat: removing single valued feature #15

merged 3 commits into from
Apr 15, 2024

Conversation

ritikgupta65
Copy link
Contributor

@ritikgupta65 ritikgupta65 commented Apr 15, 2024 •
edited
Loading

Description

I have removed the single valued features by extracting the unique value of each column

Semver Changes

  • Patch (bug fix, no new features)
  • Minor (new features, no breaking changes)
  • Major (breaking changes)

#10

List any issues that this pull request closes.

Checklist

TheMimikyu
TheMimikyu reviewed Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@TheMimikyu TheMimikyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You had created a new file new_notebook.ipynb instead of the changes being made in notebook.ipynb. But I have edited your PR to prevent the same.

TheMimikyu
TheMimikyu approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@TheMimikyu TheMimikyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 !

@TheMimikyu TheMimikyu added PR:Accept PR has been accepted and is merged Semver:minor PR will force a minor update in repo and includes new features and backward compatibility Type:Easy PR is accepted with difficulty level as easy labels Apr 15, 2024
@TheMimikyu TheMimikyu merged commit e48068a into OPCODE-Open-Spring-Fest:main Apr 15, 2024
3 of 5 checks passed
@TheMimikyu TheMimikyu mentioned this pull request Apr 15, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMimikyu TheMimikyu TheMimikyu approved these changes

Assignees
No one assigned
Labels
PR:Accept PR has been accepted and is merged Semver:minor PR will force a minor update in repo and includes new features and backward compatibility Type:Easy PR is accepted with difficulty level as easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritikgupta65 @TheMimikyu