Skip to content

Commit

Permalink
add resource requests for the proxy container (#219)
Browse files Browse the repository at this point in the history
* add resource requests for the proxy container

* [ci skip] auto patch increment
skip-checks: true

Co-authored-by: ras-rm-bot <[email protected]>
  • Loading branch information
jterryons and ras-rm-bot authored Dec 3, 2020
1 parent 7bdd8d1 commit e96731a
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 10 deletions.
2 changes: 1 addition & 1 deletion _infra/helm/collection-exercise/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ version: 1.2.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 11.0.28
appVersion: 11.0.29

4 changes: 3 additions & 1 deletion _infra/helm/collection-exercise/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ spec:
secretKeyRef:
name: db-config
key: db-port
resources:
{{- toYaml .Values.resources.proxy | nindent 12 }}
{{- end }}
- name: {{ .Chart.Name }}
{{- if eq .Values.image.tag "latest"}}
Expand Down Expand Up @@ -290,4 +292,4 @@ spec:
- name: ACTION_SVC_DEPRECATED
value: "{{ .Values.deprecateAction }}"
resources:
{{- toYaml .Values.resources | nindent 12 }}
{{- toYaml .Values.resources.application | nindent 12 }}
24 changes: 16 additions & 8 deletions _infra/helm/collection-exercise/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,26 @@ service:
port: 8080

resources:
requests:
memory: "500Mi"
cpu: "25m"
limits:
memory: "1000Mi"
cpu: "100m"
application:
requests:
memory: "500Mi"
cpu: "35m"
limits:
memory: "2000Mi"
cpu: "1000m"
proxy:
requests:
memory: "25Mi"
cpu: "5m"
limits:
memory: "64Mi"
cpu: "100m"

autoscaling: false
scaleAt:
# These are expressed as a percentage of resources.requests, not resources.limits
memoryPercentage: 150
cpuPercentage: 200
memoryPercentage: 200
cpuPercentage: 500
replicas: 1
rollingUpdate:
maxSurge: 1
Expand Down

0 comments on commit e96731a

Please sign in to comment.