Skip to content

Commit

Permalink
created database migration for deleting tables and procedures (#212)
Browse files Browse the repository at this point in the history
* created database migration for deleting tables and procedures

* [ci skip] auto patch increment
skip-checks: true

Co-authored-by: ras-rm-bot <[email protected]>
  • Loading branch information
anwilkie and ras-rm-bot authored Nov 19, 2020
1 parent 44b891a commit d8fd645
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 4 deletions.
3 changes: 0 additions & 3 deletions IMPROVEMENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,6 @@
Holds association between collection exercise and action plan id
#### `samplelink`
Holds collection-exercise and sample summary id
#### `messagelog`
Holds job id and message information.


## improvements
Expand All @@ -150,7 +148,6 @@
but it does interact with multiple services to carry out its function.
This service can be simplified by improving existing service, a rewrite might not be necessary.
* DB structure need to be improved to provide more viable link and relationship between tables.
* Remove `report` and `reporttype` table. I haven't seen its usage.
* Remove `sampleunittype` as it can easily be removed by a static value.
* Remove the use of XML/XSD and replace with JSON.
* Improving service to propagate the changes to action for any changes. Few of the function does not seem to propagate
Expand Down
2 changes: 1 addition & 1 deletion _infra/helm/collection-exercise/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ version: 1.2.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 11.0.22
appVersion: 11.0.23
11 changes: 11 additions & 0 deletions src/main/resources/database/changes/release-12/changelog.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
databaseChangeLog:

- changeSet:
id: 12.1
author: Adam Wilkie
changes:
- sqlFile:
comment: Remove report table and procedures
path: remove_report_table_and_procedures.sql
relativeToChangelogFile: true
splitStatements: false
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
DROP TABLE [IF EXISTS]
collectionexercise.messagelog,
collectionexercise.report,
collectionexercise.reporttype;
DROP FUNCTION [IF EXISTS]
collectionexercise.generate_collectionexercise_mi,
collectionexercise.logmessage;

0 comments on commit d8fd645

Please sign in to comment.