Maven surefire not running and failing test and warnings #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pricem14pc
commented
Oct 14, 2024
src/test/java/uk/gov/ons/ctp/response/casesvc/state/StateTransitionManagerUnitTest.java
Outdated
Show resolved
Hide resolved
pricem14pc
commented
Oct 14, 2024
src/test/java/uk/gov/ons/ctp/response/casesvc/state/StateTransitionManagerUnitTest.java
Outdated
Show resolved
Hide resolved
…itionManagerUnitTest.java Rename var
…itionManagerUnitTest.java Rename var
arroyoAle
approved these changes
Oct 14, 2024
matthew-robinson-ons
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Unit tests weren't running as surefire plugin wasn't configured correctly. Only the failsafe integration tests were running.
Also we were seeing various warnings and one of the tests was failing when run so there are changes to resolve those.
How to test?
Check the unit tests are running and passing in Github Actions and locally using
mvn clean install. There were ~158 unit tests not running previously.Jira