Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename NOT_ENGLAND variable to NI_REGION_CODE #280

Merged
merged 4 commits into from
Sep 25, 2023
Merged

rename NOT_ENGLAND variable to NI_REGION_CODE #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9b1569
rename NOT_ENGLAND variable to NI_REGION_CODE to make a little more s…
JacobHarrisonONS Sep 20, 2023
c536873
auto patch increment
ras-rm-pr-bot Sep 20, 2023
a81a84e
update comment
JacobHarrisonONS Sep 21, 2023
7c7aab3
Merge remote-tracking branch 'origin/region-code-name-fix' into regio…
JacobHarrisonONS Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _infra/helm/case/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 12.0.13
version: 12.0.14

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 12.0.13
appVersion: 12.0.14
6 changes: 3 additions & 3 deletions src/main/java/uk/gov/ons/ctp/response/casesvc/representation/action/NotifyModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public static class ClassifiersBuilder {
private static final String REMINDER = "REMINDER";
private static final String NOTIFICATION = "NOTIFICATION";
// a region of YY appears to be any region that isnt england
private static final String NOT_ENGLAND = "YY";
private static final String NI_REGION_CODE = "YY";

private String actionType;
private String legalBasis;
Expand All @@ -115,8 +115,8 @@ public Classifiers build() {
return new Classifiers(actionType, "", "", "", "");
}

// if not not england is england. welcome to ras-rm.
if (!NOT_ENGLAND.equals(region)) {
// if NOT NI then England/Wales
if (!NI_REGION_CODE.equals(region)) {
region = "";
}

Expand Down