Allow the hub to be enabled with repeating sections #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berroar
changed the title
berroar
force-pushed
the
require-repeating-sections-before-hub
branch
from
1e3b301 to
e3c59c5
Compare
liamtoozer
reviewed
Jan 31, 2024
tests/functional/spec/features/hub_and_spoke/hub_and_spoke.spec.js
Outdated
Show resolved
Hide resolved
tests/functional/spec/features/hub_and_spoke/hub_and_spoke.spec.js
Outdated
Show resolved
Hide resolved
tests/functional/spec/features/hub_and_spoke/hub_and_spoke.spec.js
Outdated
Show resolved
Hide resolved
…c.js Co-authored-by: Mebin Abraham <[email protected]>
…c.js Co-authored-by: Mebin Abraham <[email protected]>
Co-authored-by: Mebin Abraham <[email protected]>
petechd
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Previously the
required_completed_sectionsfield in our schemas did not work for repeating sections. This change allows the hub to be toggled on/off based the completeness of a repeating section.How to review
Use the
test_hub_section_required_with_repeatschema, and check that you are only able to access the hub page once you have completed all of the repeating sections. Also addedtest_hub_section_required_with_repeat_supplementaryto demo the same functionality with a repeating section that is being populated with a list sourced from supplementary data.Checklist