Refactor the list collector repeating blocks functional test spec #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/functional/spec/features/repeating_blocks/list_collector_repeating_blocks.spec.js
Show resolved
Hide resolved
tests/functional/spec/features/repeating_blocks/list_collector_repeating_blocks.spec.js
Outdated
Show resolved
Hide resolved
tests/functional/spec/features/repeating_blocks/list_collector_repeating_blocks.spec.js
Outdated
Show resolved
Hide resolved
katie-gardner
approved these changes
Nov 1, 2023
Yuyuutsu
approved these changes
Nov 1, 2023
VirajP1002
reviewed
Nov 1, 2023
tests/functional/spec/features/repeating_blocks/list_collector_repeating_blocks.spec.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Refactored the tests in the list collector repeating blocks spec file. Needed to be refactored as some of the test cases were missing assertions or were executing additional steps after assertions. All tests should now be following the Given, When, Then pattern.
How to review
Check that the changes make sense and that the functional test still passes. Are any test cases missing?
Checklist