Updating makefile commands #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d when calling make format and make lint
berroar
requested changes
Oct 10, 2023
…calling the command on JS/Python
katie-gardner
suggested changes
Oct 10, 2023
|
Test slack comment. Ignore. |
katie-gardner
approved these changes
Oct 13, 2023
berroar
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
https://github.com/ONSdigital/eq-questionnaire-runner/blob/main/.github/workflows/pull_request.yml This should be updated to make use of any make commands we have available. There are references to yarn and direct calls to .sh files
katie-gardner
approved these changes
Oct 20, 2023
petechd
approved these changes
Oct 20, 2023
berroar
approved these changes
Oct 20, 2023
MebinAbraham
approved these changes
Oct 20, 2023
Yuyuutsu
approved these changes
Oct 20, 2023
MebinAbraham
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Added more bespoke commands to the Makefile to streamline development processes
How to review
make validate-test-schemato ensure the single schema is validatedmake test-single-functional&make test-suite-functional:to ensure the specified single spec/suite is runmake test-lint-jsto ensure both JS lint and JS tests are runmake test-lint-pythonto ensure both Python lint and Python tests are runmake test-functional-headlessto ensure functional tests are run headlessChecklist