-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dev and test configs to streamline developer experience #76
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - followed instructions which worked 🫡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of very minor suggestions, otherwise it works well.
Locally have to use poetry run ./manage.py test ...
as make test
does fail with AttributeError: 'DatabaseWrapper' object has no attribute '_test_serialized_contents'
and while tempting, we have many other tasks to get on with
Co-authored-by: Dan Braghiș <[email protected]>
Co-authored-by: Dan Braghiș <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is marked improvement. 👍🏼 from me
What is the context of this PR?
Update the development and test defaults, so that running the app and tests locally works out of the box, without setting additional environment variables. Developing and testing in the docker container should also still work with no addtional steps, as the compose file already overrides the environment variables to its needs.
How to review
.env
files or environment configuration you previously had for native local developmentDJANGO_SETTINGS_MODULE
, if you are running by a method other than themake runserver
command, as the README says).make test
command, if this fails with an error try runningpoetry run coverage run ./manage.py test --shuffle --settings=cms.settings.test
instead to run them in series.Follow-up Actions
None