Tidy up the info/warning panel and fix title/no title output #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nehakerung
reviewed
Jan 10, 2025
|
@nehakerung thank you for the comprehensive testing. As the note in PR description says, warning and announcement have an issue, and that was flagged to the Design System team. We're using the component directly, so it needs fixing in the DS. Perhaps @helenb could help with that when she does some DS work |
AdamHawtin
approved these changes
Jan 10, 2025
nehakerung
approved these changes
Jan 10, 2025
sanjeevz3009
approved these changes
Jan 10, 2025
ababic
added a commit
that referenced
this pull request
Jan 16, 2025
* main: Update the embed block to be a custom video embed that uses the design system video embed template (#62) Django Migration Linter Integration (#43) Tidy up the info/warning panel and fix title/no title output (#73) Introduce Functional Tests using Playwright and Behave #31 # Conflicts: # poetry.lock # pyproject.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This came up in a couple of conversations (Mike, Julia/Gill) and the main question was "where is the information panel?" (and "what is warn (branded) or ghost?")
So this PR tidies up the panel block choices remove the ones that are not listed on https://service-manual.ons.gov.uk/design-system/components (and dropping bare too). It adds the "information" choice and fixes the output for it when there is no title
How to review
Add a panel block on an information page or methodology page and check its output with various types.
Note
The panel component has an issue where the title overlaps the icon for the warning and announcement variants. DS issue for warning
Follow-up Actions
N/A