Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inplace cosserat stress #442

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Inplace cosserat stress #442

merged 4 commits into from
Aug 21, 2023

Conversation

mvanzulli
Copy link
Member

@mvanzulli mvanzulli commented Aug 12, 2023

Closes #437

Main

"uniaxial_extension" => 5-element BenchmarkTools.BenchmarkGroup:
    "solve, ms = 0.3, nelems = 580, nnodes = 201" => Trial(16.441 ms)
    "solve, ms = 0.1, nelems = 9292, nnodes = 2147" => Trial(300.951 ms)
    "solve, ms = 0.2, nelems = 1343, nnodes = 400" => Trial(39.159 ms)
    "solve, ms = 0.5, nelems = 144, nnodes = 62" => Trial(3.747 ms)
    "solve, ms = 0.4, nelems = 256, nnodes = 107" => Trial(7.018 ms)
"uniaxial_compression" => 5-element BenchmarkTools.BenchmarkGroup:
    "solve, ms = 0.3, nelems = 580, nnodes = 201" => Trial(14.801 ms)
    "solve, ms = 0.1, nelems = 9292, nnodes = 2147" => Trial(281.064 ms)
    "solve, ms = 0.2, nelems = 1343, nnodes = 400" => Trial(35.352 ms)
    "solve, ms = 0.5, nelems = 144, nnodes = 62" => Trial(3.412 ms)
    "solve, ms = 0.4, nelems = 256, nnodes = 107" => Trial(6.384 ms)

This branch

"uniaxial_extension" => 5-element BenchmarkTools.BenchmarkGroup:
    tags: []
    "solve, ms = 0.3, nelems = 580, nnodes = 201" => Trial(16.355 ms)
    "solve, ms = 0.1, nelems = 9292, nnodes = 2147" => Trial(294.047 ms)
    "solve, ms = 0.2, nelems = 1343, nnodes = 400" => Trial(38.229 ms)
    "solve, ms = 0.5, nelems = 144, nnodes = 62" => Trial(3.793 ms)
    "solve, ms = 0.4, nelems = 256, nnodes = 107" => Trial(7.040 ms)
"uniaxial_compression" => 5-element BenchmarkTools.BenchmarkGroup:
    tags: []
    "solve, ms = 0.3, nelems = 580, nnodes = 201" => Trial(14.415 ms)
    "solve, ms = 0.1, nelems = 9292, nnodes = 2147" => Trial(275.075 ms)
    "solve, ms = 0.2, nelems = 1343, nnodes = 400" => Trial(34.459 ms)
    "solve, ms = 0.5, nelems = 144, nnodes = 62" => Trial(3.317 ms)
    "solve, ms = 0.4, nelems = 256, nnodes = 107" => Trial(6.192 ms)

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2023

Codecov Report

Merging #442 (d604f2e) into main (9fd583c) will increase coverage by 0.03%.
The diff coverage is 98.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   86.83%   86.87%   +0.03%     
==========================================
  Files          43       43              
  Lines        1679     1684       +5     
==========================================
+ Hits         1458     1463       +5     
  Misses        221      221              
Files Changed Coverage Δ
src/Materials/HyperElasticMaterials.jl 0.00% <0.00%> (ø)
src/Materials/LinearElasticMaterials.jl 0.00% <ø> (ø)
src/Entities/Tetrahedrons.jl 98.42% <100.00%> (ø)
src/Entities/Trusses.jl 98.80% <100.00%> (ø)
src/Materials/HyperElasticMaterial.jl 100.00% <100.00%> (ø)
src/Materials/NeoHookeanMaterial.jl 89.79% <100.00%> (ø)
src/Materials/SVKMaterial.jl 100.00% <100.00%> (ø)
src/StructuralAnalyses/StaticStates.jl 87.80% <100.00%> (ø)
src/StructuralAnalyses/StructuralAnalyses.jl 81.25% <100.00%> (ø)
src/Utils.jl 96.00% <100.00%> (+1.88%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mvanzulli mvanzulli marked this pull request as ready for review August 12, 2023 14:51
@mvanzulli mvanzulli requested a review from mforets August 12, 2023 14:51
@mforets
Copy link
Collaborator

mforets commented Aug 19, 2023

fine with the changes, but the result is not noticeable on such bench, right?

did you compare the allocs as well?

@mvanzulli
Copy link
Member Author

fine with the changes, but the result is not noticeable on such bench, right?

did you compare the allocs as well?

Yes, however there are not noticeable differences in allocations. Tenosors.jl does not provide an in-place operation computing the derivatives via Automatic Differentiation

@mvanzulli mvanzulli merged commit d06eecc into main Aug 21, 2023
4 checks passed
@mvanzulli mvanzulli deleted the mvanzulli/437_2 branch August 21, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inplace computation of stress tensors
3 participants