Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/debug: increase max length of message #12192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

regit
Copy link
Contributor

@regit regit commented Dec 1, 2024

Update of #12183

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/

Describe changes:

  • Increase size to take into account the file name
  • Better commit message

SV_BRANCH=OISF/suricata-verify#2152

When a signature is incorrect, its full content is logged in a
message with some other information such as rules file name. As
a result, the log message must be longer than a maximum signature
length which is 8192.

Ticket: 7419
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23620

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.15%. Comparing base (287d836) to head (23e6b9a).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12192       +/-   ##
===========================================
+ Coverage   49.98%   83.15%   +33.16%     
===========================================
  Files         912      912               
  Lines      257066   257066               
===========================================
+ Hits       128503   213766    +85263     
+ Misses     128563    43300    -85263     
Flag Coverage Δ
fuzzcorpus 61.01% <100.00%> (+0.02%) ⬆️
livemode 19.41% <100.00%> (-0.01%) ⬇️
pcap 44.41% <100.00%> (+<0.01%) ⬆️
suricata-verify 62.70% <100.00%> (-0.02%) ⬇️
unittests 59.17% <100.00%> (+50.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants