next/648/20241128/v1 #12174
Merged
next/648/20241128/v1 #12174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a more compact set of trees specifically for IPv4 and IPv6 addresses. This allows for more compact data structures and fewer memory allocations. Based on the existing radix tree implementation.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Use a more compact ipv4 specific structure.
Use a more compact ipv6 specific structure.
No longer used.
Rename types enum to reflect it is not using a radix tree anymore.
Move repeated pattern into helper function.
- DetectEngineInspectBufferHttpHeader is only used with ALPROTO_HTTP1 - engine->progress should be HTP_REQUEST_HEADERS or HTP_RESPONSE_HEADERS based on the direction
Ticket: 2224 It takes an argument to match only if the buffer is absent, or it can still match if the buffer is present, but we test the absence of some content. For multi buffers, absent matches if there are 0 buffers. For file keywords, absent matches if there is no file.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12174 +/- ##
==========================================
- Coverage 49.81% 49.75% -0.06%
==========================================
Files 909 912 +3
Lines 257904 257055 -849
==========================================
- Hits 128467 127895 -572
+ Misses 129437 129160 -277
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23593 |
jasonish
approved these changes
Nov 28, 2024
This was referenced Nov 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#2150