output: Add linktype name #11994
Closed
output: Add linktype name #11994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11994 +/- ##
==========================================
+ Coverage 82.75% 83.23% +0.48%
==========================================
Files 910 912 +2
Lines 249016 258234 +9218
==========================================
+ Hits 206069 214945 +8876
- Misses 42947 43289 +342
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Issue: 6954 Add Rust based logic that maintains a hash map of link type values and their associated output names.
Use the hasmap to gather linktype display names. Issue: 6954
Issue: 6954 This commit adds the linktype name to the output stream. The name is determined from the pcap utility function pcap_datalink_val_to_name
|
Information: QA ran without warnings. Pipeline 23138 |
|
Information: QA ran without warnings. Pipeline 23139 |
|
Passed my QA. Ran this PR with SV PR OISF/suricata-verify#2023. Local pipeline 5099, run 613. |
jlucovsky
requested review from
jasonish,
victorjulien and
a team
as code owners
|
This looks ok to me, but you are aware that a DLT_RAW created on openBSD and read elsewhere will not show as such, right ? |
|
Continued in #12142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #11670
Issue: 6954
This commit adds the linktype name to the output stream. The name is determined from a Rust linktype-to-name function.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6954
Describe changes:
Updates:
Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#2023