Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds tests for negated content and absent keyword #1957

Closed
wants to merge 1 commit into from
Closed

Adds tests for negated content and absent keyword #1957

wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Collaborator

Ticket

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/2224

#1942 with more tests

  • engine analysis test
  • checks with absent keyword and positive content

@catenacyber catenacyber added the requires suricata pr Depends on a PR in Suricata label Jul 4, 2024
This was referenced Jul 4, 2024
Closed
Closed
inashivb
inashivb reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good. 🌟
Gonna take another pass at the Suricata code before approving.

@catenacyber catenacyber mentioned this pull request Jul 9, 2024
Closed
@catenacyber catenacyber force-pushed the detect-negated-content-absent-buffer-2224-v10 branch 2 times, most recently from cfd4011 to 012c150 Compare July 10, 2024 06:33
inashivb
inashivb approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jufajardini
Copy link
Contributor

Having the engine-analysis test is nice, thanks! :)

@catenacyber catenacyber mentioned this pull request Jul 15, 2024
Closed
@catenacyber catenacyber force-pushed the detect-negated-content-absent-buffer-2224-v10 branch from 012c150 to a4c53c8 Compare July 15, 2024 19:04
@catenacyber catenacyber force-pushed the detect-negated-content-absent-buffer-2224-v10 branch from a4c53c8 to 716a90a Compare October 8, 2024 15:04
This was referenced Oct 8, 2024
Closed
Closed
@catenacyber catenacyber force-pushed the detect-negated-content-absent-buffer-2224-v10 branch from 716a90a to 3ec563b Compare November 12, 2024 15:41
@catenacyber catenacyber force-pushed the detect-negated-content-absent-buffer-2224-v10 branch from 3ec563b to a6a9a98 Compare November 27, 2024 20:44
@catenacyber catenacyber mentioned this pull request Nov 27, 2024
Closed
@victorjulien victorjulien mentioned this pull request Nov 28, 2024
Merged
@victorjulien
Copy link
Member

Merged in #2150, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inashivb inashivb inashivb approved these changes

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catenacyber @jufajardini @victorjulien @inashivb