Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor I/O read/write APIs to return ValueTask instead of Task #2975

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Fix component benchmarks

b88b015
Select commit
Loading
Failed to load commit list.
Draft

Refactor I/O read/write APIs to return ValueTask instead of Task #2975

Fix component benchmarks
b88b015
Select commit
Loading
Failed to load commit list.
Azure Pipelines / OData-main-pipeline-Rolling failed May 22, 2024 in 3m 45s

Build #OData_OData-main-pipeline-Rolling_merge_20240522.3 failed

Annotations

Check failure on line 165 in test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationReaderTests.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / OData-main-pipeline-Rolling

test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationReaderTests.cs#L165

test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationReaderTests.cs(165,49): Error CS0738: 'ODataNotificationReaderTests.MockODataStreamListener' does not implement interface member 'IODataStreamListener.StreamRequestedAsync()'. 'ODataNotificationReaderTests.MockODataStreamListener.StreamRequestedAsync()' cannot implement 'IODataStreamListener.StreamRequestedAsync()' because it does not have the matching return type of 'ValueTask'.

Check failure on line 165 in test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationReaderTests.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / OData-main-pipeline-Rolling

test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationReaderTests.cs#L165

test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationReaderTests.cs(165,49): Error CS0738: 'ODataNotificationReaderTests.MockODataStreamListener' does not implement interface member 'IODataStreamListener.StreamDisposedAsync()'. 'ODataNotificationReaderTests.MockODataStreamListener.StreamDisposedAsync()' cannot implement 'IODataStreamListener.StreamDisposedAsync()' because it does not have the matching return type of 'ValueTask'.

Check failure on line 131 in test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationStreamTests.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / OData-main-pipeline-Rolling

test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationStreamTests.cs#L131

test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationStreamTests.cs(131,49): Error CS0738: 'ODataNotificationStreamTests.MockODataStreamListener' does not implement interface member 'IODataStreamListener.StreamRequestedAsync()'. 'ODataNotificationStreamTests.MockODataStreamListener.StreamRequestedAsync()' cannot implement 'IODataStreamListener.StreamRequestedAsync()' because it does not have the matching return type of 'ValueTask'.

Check failure on line 131 in test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationStreamTests.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / OData-main-pipeline-Rolling

test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationStreamTests.cs#L131

test\FunctionalTests\Microsoft.OData.Core.Tests\ODataNotificationStreamTests.cs(131,49): Error CS0738: 'ODataNotificationStreamTests.MockODataStreamListener' does not implement interface member 'IODataStreamListener.StreamDisposedAsync()'. 'ODataNotificationStreamTests.MockODataStreamListener.StreamDisposedAsync()' cannot implement 'IODataStreamListener.StreamDisposedAsync()' because it does not have the matching return type of 'ValueTask'.