-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore changes to test files in PR Quantifier #2505
base: release-7.x
Are you sure you want to change the base?
Conversation
The PR Quantifier currently complains about PRs over 200 lines of code, but with test changes even minor PRs exceed that boundary. Adding a prquantifier.yaml file to limit the quantifier to look at code in the source directory.
Set medium limit to 200
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
IgnoreComments: true | ||
IgnoreCodeBlockSeparator: true | ||
DynamicBehaviour: false | ||
IgnoreRenamed: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming files in c# usually results in renaming classes, which although only tedious, I think we might want to reflect in the PR size
IgnoreRenamed: true | |
IgnoreRenamed: false |
IgnoreCodeBlockSeparator: true | ||
DynamicBehaviour: false | ||
IgnoreRenamed: true | ||
IgnoreCopied: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure what this means, but if someone copy/pastes something and then only changes 5% of it, the whole thing needs to be confirmed for correctness, so we probably want to include this in the size as well
IgnoreCopied: true | |
IgnoreCopied: false |
DynamicBehaviour: false | ||
IgnoreRenamed: true | ||
IgnoreCopied: true | ||
AdditionPercentile: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do these figures represent?
Description
The PR Quantifier currently complains about PRs over 200 lines of code, but with test changes even minor PRs exceed that boundary.
Adding a prquantifier.yaml file to limit the quantifier to look at code in the source directory.
Additional work necessary
If this works on this repo, we should add similar logic to the other repos as well.