adding queryable extensions to DataServiceQuery<T> #2475

corranrogue9 · 2022-08-06T00:12:07Z

Issues

This pull request fixes #2409.

Description

From the issue, when a DataServiceQuery<T> is used as an IQueryable<T> for LINQ queries, the returned object is IQueryable<T>. This means that it cannot be passed to DataServiceContext.ExecuteBatch. To facilitate this, we will now have custom extension methods for DataServiceQuery<T> which are analogs to those extensions on IQueryable<T>, except they return DataServiceQuery<T> variants. This will allow them to still be used in DataServiceContext.ExecuteBatch. An explanation of the options discussed can be found here.

pull-request-quantifier-deprecated · 2022-08-06T00:12:12Z

This PR has 881 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +881 -0
Percentile : 96.03%

Total files changed: 9

Change summary by file extension:
.cs : +244 -0
.txt : +52 -0
.vb : +153 -0
.bsl : +432 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

xuzhg · 2022-08-09T21:26:01Z

src/Microsoft.OData.Client/DataServiceQueryExtensions.cs

@@ -0,0 +1,1035 @@
+//---------------------------------------------------------------------
+// <copyright file="DataServiceQueryOfT.cs" company="Microsoft">


DataServiceQueryOfT

update

xuzhg · 2022-08-09T21:30:39Z

src/Microsoft.Spatial/OrderedQueryableExtensions.cs

+    /// Extension methods for <see cref="IOrderedQueryable{T}"/>
+    /// </summary>
+    /// <threadsafety static="true"/>
+    public static class OrderedQueryableExtensions


any reason why do we add this in the Microsoft.Spatial project.

xuzhg · 2022-08-09T21:30:49Z

namespace Microsoft.Spatial

copyright

Refers to: src/Microsoft.Spatial/OrderedQueryableExtensions.cs:1 in 9ff29b2. [](commit_id = 9ff29b2, deletion_comment = False)

xuzhg · 2022-08-09T21:31:20Z

src/Microsoft.Spatial/OrderedQueryableExtensions.cs

+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        public static IOrderedQueryable<T> AsOrderedQueryable<T>(this IOrderedQueryable<T> queryable)
+        {
+            return queryable;


return queryable;

just returns the input? do nothing

xuzhg · 2022-08-09T21:31:28Z

src/Microsoft.Spatial/QueryableExtensions.cs

+        public static IQueryable<T> AsQueryable<T>(this IQueryable<T> queryable)
+        {
+            return queryable;
+        }


any reason why do we add this in the Microsoft.Spatial project.

xuzhg · 2022-08-09T21:31:37Z

src/Microsoft.Spatial/QueryableExtensions.cs

@@ -0,0 +1,24 @@
+namespace Microsoft.Spatial
+{


KenitoInc

Can we have some unit or E2E tests on how these extensions can be used. E.g in ExecuteBatch as described in the issue.

KenitoInc · 2022-09-01T08:32:56Z

src/Microsoft.Spatial/OrderedQueryableExtensions.cs

+    /// Extension methods for <see cref="IOrderedQueryable{T}"/>
+    /// </summary>
+    /// <threadsafety static="true"/>
+    public static class OrderedQueryableExtensions


KenitoInc · 2022-09-01T08:34:28Z

src/Microsoft.OData.Client/DataServiceQueryExtensions.cs

@@ -0,0 +1,1035 @@
+//---------------------------------------------------------------------
+// <copyright file="DataServiceQueryOfT.cs" company="Microsoft">


Suggested change

// <copyright file="DataServiceQueryOfT.cs" company="Microsoft">

// <copyright file="DataServiceQueryExtensions.cs" company="Microsoft">

KenitoInc · 2022-09-01T08:34:53Z

src/Microsoft.OData.Client/DataServiceQueryExtensions.cs

+    using System.Collections.Generic;
+    using System.Linq;
+    using System.Linq.Expressions;
+


Suggested change

KenitoInc · 2022-09-01T08:35:36Z

src/Microsoft.OData.Client/DataServiceQueryExtensions.cs

+    using System.Linq;
+    using System.Linq.Expressions;
+
+    using Microsoft.Spatial;


We shouldn't be having extensions in the spatial project.

adding queryable extensions to DataServiceQuery<T>

9ff29b2

pull-request-quantifier-deprecated bot added the Extra Large label Aug 6, 2022

xuzhg reviewed Aug 9, 2022

View reviewed changes

src/Microsoft.Spatial/QueryableExtensions.cs

@@ -0,0 +1,24 @@

namespace Microsoft.Spatial

{

Copy link

Member

xuzhg Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright

KenitoInc requested review from KenitoInc, chrisspre, ElizabethOkerio, gathogojr, habbes and Nthemba August 17, 2022 11:47

KenitoInc requested changes Sep 1, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding queryable extensions to DataServiceQuery<T> #2475

adding queryable extensions to DataServiceQuery<T> #2475

corranrogue9 commented Aug 6, 2022

pull-request-quantifier-deprecated bot commented Aug 6, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

xuzhg Aug 9, 2022

xuzhg Aug 9, 2022

KenitoInc Sep 1, 2022

xuzhg commented Aug 9, 2022

xuzhg Aug 9, 2022

xuzhg Aug 9, 2022

xuzhg Aug 9, 2022

KenitoInc left a comment

KenitoInc Sep 1, 2022

KenitoInc Sep 1, 2022

KenitoInc Sep 1, 2022

KenitoInc Sep 1, 2022

		@@ -0,0 +1,1035 @@
		//---------------------------------------------------------------------
		// <copyright file="DataServiceQueryOfT.cs" company="Microsoft">

	// <copyright file="DataServiceQueryOfT.cs" company="Microsoft">
	// <copyright file="DataServiceQueryExtensions.cs" company="Microsoft">

adding queryable extensions to DataServiceQuery<T> #2475

Are you sure you want to change the base?

adding queryable extensions to DataServiceQuery<T> #2475

Conversation

corranrogue9 commented Aug 6, 2022

Issues

Description

pull-request-quantifier-deprecated bot commented Aug 6, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xuzhg commented Aug 9, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KenitoInc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment