Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle request in order. #767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MitchKuijpers
Copy link
Contributor

Issues

*This pull request fixes issue #762

Description

I tried to find a method to check for the depends on id but could not find one. So the only fix for now would be resolving them in order. This is many times slower, but it's better then it being broken.

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

@MartinTopfstedtSinc
Copy link

Does this work? I tried this myself but for some reason it waited inside the Controller for the other requests to finish until it populates the Response to the ChangeSet. (

await changeSetProperty.OnChangeSetCompleted().ConfigureAwait(false);
)

@MitchKuijpers
Copy link
Contributor Author

I'm not sure what you mean by that. I built it with this change and tested it both locally and in our test environment. However, it's really slow now. For that batches, but it works good for a single changeset where I don't want any entities saved when one fails.

That said, even if we want a "good" fix, we should only process the entities that have dependencies in the correct order. But I don't really see the need for this added complexity.

Personally, I would prefer providing a header to make the request asynchronous or perhaps creating two separate endpoints. I'm not entirely confident about what OData expects here. (I believe the standard Microsoft batch handler doesn't process requests in parallel, but what does it do with the dependsOn ID? Nothing?)

robertmclaws added a commit that referenced this pull request Nov 24, 2024
- Sequential batch processing (via @MitchKuijpers on #767)
- Removing .NET 6 and 7 as out of dupport
- Moving .NET Framework to 4.8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants