Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Spec - Schema #236

Closed
wants to merge 15 commits into from
Closed

QA Spec - Schema #236

wants to merge 15 commits into from

Conversation

kba
Copy link
Member

@kba kba commented Dec 19, 2022

Just the (still evolving) schema, so #225 can focus on the spec itself.

kba added a commit that referenced this pull request Dec 19, 2022
@kba kba mentioned this pull request Dec 19, 2022
ocrd_eval.sample.json Outdated Show resolved Hide resolved
@mweidling
Copy link
Contributor

processing_time as benchmark for a page is only given in the example files and not defined in the schema YAML. Since it's a bit tricky to calculate it I also wanted to know what the overall value of this is. If it doesn't have that much of a value I recommend to toss it and focus on pages_per_minute instead.

@kba What do you think?

ocrd_eval.schema.json Outdated Show resolved Hide resolved
ocrd_eval.schema.yml Outdated Show resolved Hide resolved
ocrd_eval.schema.yml Outdated Show resolved Hide resolved
ocrd_eval.schema.yml Outdated Show resolved Hide resolved
ocrd_eval.schema.yml Outdated Show resolved Hide resolved
ocrd_eval.schema.yml Outdated Show resolved Hide resolved
@kba
Copy link
Member Author

kba commented Jan 27, 2023

processing_time as benchmark for a page is only given in the example files and not defined in the schema YAML. Since it's a bit tricky to calculate it I also wanted to know what the overall value of this is. If it doesn't have that much of a value I recommend to toss it and focus on pages_per_minute instead.

@kba What do you think?

That was an oversight that it's not in the schema. Why is it tricky to calculate or rather, how would you calculate pages_per_minute without it?

ocrd_eval.schema.yml Outdated Show resolved Hide resolved
ocrd_eval.schema.yml Outdated Show resolved Hide resolved
ocrd_eval.schema.yml Show resolved Hide resolved
ocrd_eval.sample.json Outdated Show resolved Hide resolved
ocrd_eval.schema.json Outdated Show resolved Hide resolved
ocrd_eval.schema.json Outdated Show resolved Hide resolved
ocrd_eval.schema.yml Outdated Show resolved Hide resolved
ocrd_eval.schema.yml Outdated Show resolved Hide resolved
@mweidling
Copy link
Contributor

processing_time as benchmark for a page is only given in the example files and not defined in the schema YAML. Since it's a bit tricky to calculate it I also wanted to know what the overall value of this is. If it doesn't have that much of a value I recommend to toss it and focus on pages_per_minute instead.
@kba What do you think?

That was an oversight that it's not in the schema. Why is it tricky to calculate or rather, how would you calculate pages_per_minute without it?

My first naive approach would be to look at the processing time for the complete work, calculate the mean processing time for a page and use this as basis for obtaining pages_per_minute. The arithmetic mean for a page cannot be used for processing_time, though, as this would imply the actual time this page took.

@kba kba marked this pull request as ready for review March 14, 2023 15:38
@kba
Copy link
Member Author

kba commented Mar 14, 2023

processing_time as benchmark for a page is only given in the example files and not defined in the schema YAML. Since it's a bit tricky to calculate it I also wanted to know what the overall value of this is. If it doesn't have that much of a value I recommend to toss it and focus on pages_per_minute instead.
@kba What do you think?

That was an oversight that it's not in the schema. Why is it tricky to calculate or rather, how would you calculate pages_per_minute without it?

My first naive approach would be to look at the processing time for the complete work, calculate the mean processing time for a page and use this as basis for obtaining pages_per_minute. The arithmetic mean for a page cannot be used for processing_time, though, as this would imply the actual time this page took.

pages_per_minute is likely the more interesting measure, so feel free to focus on that.

@mweidling
Copy link
Contributor

processing_time as benchmark for a page is only given in the example files and not defined in the schema YAML. Since it's a bit tricky to calculate it I also wanted to know what the overall value of this is. If it doesn't have that much of a value I recommend to toss it and focus on pages_per_minute instead.
@kba What do you think?

That was an oversight that it's not in the schema. Why is it tricky to calculate or rather, how would you calculate pages_per_minute without it?

My first naive approach would be to look at the processing time for the complete work, calculate the mean processing time for a page and use this as basis for obtaining pages_per_minute. The arithmetic mean for a page cannot be used for processing_time, though, as this would imply the actual time this page took.

pages_per_minute is likely the more interesting measure, so feel free to focus on that.

Let's skip processing_time for pages then for now. I'll make an issue so that we can implement it in a later stage.

@kba
Copy link
Member Author

kba commented Mar 16, 2023

Sry, I accidentally rebased instead of merging, but it is all in master now.

@kba kba closed this Mar 16, 2023
@mweidling
Copy link
Contributor

Sry, I accidentally rebased instead of merging, but it is all in master now.

Alright, thank you!

@mweidling
Copy link
Contributor

I'll remove the branch then.

@kba kba deleted the qa-spec-schema branch March 21, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants